Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update and cleanup tutorials and examples #815

Merged
merged 14 commits into from
Mar 14, 2024
Merged

docs: update and cleanup tutorials and examples #815

merged 14 commits into from
Mar 14, 2024

Conversation

sathvikbhagavan
Copy link
Member

No description provided.

ChrisRackauckas
ChrisRackauckas reviewed Feb 21, 2024
View reviewed changes
docs/src/examples/nonlinear_elliptic.md
strategy = QuadratureTraining()
strategy = GridTraining(0.01)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't default to grid training.

@ChrisRackauckas
Copy link
Member

Looks like tests fail?

@sathvikbhagavan
Copy link
Member Author

sathvikbhagavan commented Feb 22, 2024 •
edited
Loading

Yeah, doc build is timing out. Currently checking examples which are slow and trying to speed it up.

@sathvikbhagavan sathvikbhagavan force-pushed the sb/docs branch 2 times, most recently from eaf48fa to 29882a2 Compare March 6, 2024 07:28
This was referenced Mar 7, 2024
Closed
Closed
@ChrisRackauckas
Copy link
Member

I'm not sure the regular queue would work because some want to use GPUs?

@sathvikbhagavan sathvikbhagavan force-pushed the sb/docs branch 2 times, most recently from fce9a16 to dd1a181 Compare March 11, 2024 09:52
@sathvikbhagavan
Copy link
Member Author

I'm not sure the regular queue would work because some want to use GPUs?

Yes, I was testing out the build times in the normal queue. I have reverted back to GPU queue

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Mar 11, 2024 •
edited
Loading

Do we know which ones take a long time? @mortenpi is it possible to make the documenter debug output spit out timing information?

@sathvikbhagavan
Copy link
Member Author

I look at the timestamps of the debug logs. I have fixed one of the tutorial which got stuck for more than 12hrs. Hopefully the build should go through this time and I will record the times for each example and tutorial.

@sathvikbhagavan sathvikbhagavan changed the title docs: update callback and qualify Adam from OptimizationOptimisers docs: update and cleanup tutorials and examples Mar 14, 2024
@ChrisRackauckas ChrisRackauckas merged commit d866eed into SciML:master Mar 14, 2024
19 of 22 checks passed
This was referenced Mar 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathvikbhagavan @ChrisRackauckas